Skip to content

Comma cleanup for #35925 #36023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

Comma cleanup for #35925 #36023

merged 1 commit into from
Sep 1, 2020

Conversation

JonathanShrek
Copy link
Contributor

Comma cleanup for #35925

@simonjayhawkins simonjayhawkins added Clean Code Style Code style, linting, code_checks labels Sep 1, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Sep 1, 2020
simonjayhawkins
simonjayhawkins approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JonathanShrek for the PR. lgtm

@MarcoGorelli MarcoGorelli merged commit e288b2b into pandas-dev:master Sep 1, 2020
@MarcoGorelli
Copy link
Member

Thanks @JonathanShrek !

@JonathanShrek
Copy link
Contributor Author

Thanks guys! I’m going to do some more tonight now that I am able to pass the checks. I think the version of black I was using might have been the problem.

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@JonathanShrek
Comma cleanup for pandas-dev#35925 (pandas-dev#36023)
ab11b92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanShrek @MarcoGorelli @simonjayhawkins